Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add an attribute to examples/completed to avoid name conflict in test concurrent runs #60

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

gberenice
Copy link
Contributor

what

  • Adds an attribute to the examples/competed root module - the MD5 hash of a timestamp. Thit adds a "random" attribute to the resources and helps to avoid resource name conflict during the concurrent runs, [e.g.]:
    Error: creating CloudWatch Logs Log Group (/aws/lambda/eg-test-sns-default): operation error CloudWatch Logs: 
    CreateLogGroup, https response error StatusCode: 400, RequestID: 1eefd044-082e-4b8e-8c3b-0b3c3f2dd8a8, 
    ResourceAlreadyExistsException: The specified log group already exists
    
  • Bumps terraform-aws-modules/notify-slack/aws to support newer Python version before 3.8 EOL

why

@gberenice gberenice requested review from a team as code owners July 11, 2024 10:30
@gberenice
Copy link
Contributor Author

/terratest

@mergify mergify bot added the triage Needs triage label Jul 11, 2024
@gberenice
Copy link
Contributor Author

/terratest

@hans-d hans-d merged commit 2c6b476 into main Jul 11, 2024
14 checks passed
@hans-d hans-d deleted the fix/tests-name-conflict branch July 11, 2024 11:57
@mergify mergify bot removed the triage Needs triage label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants